Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylelint 14 업데이트 및 stylelint-config 변경 #158

Merged
merged 6 commits into from Nov 9, 2021

Conversation

drakang4
Copy link
Contributor

@drakang4 drakang4 commented Nov 5, 2021

stylelint-config-recommended -> stylelint-config-standard
#157

stylelint-config-prettier를 추가합니다.
https://github.com/prettier/stylelint-config-prettier

stylelint를 14 버전으로 업데이트 합니다
https://stylelint.io/migration-guide/to-14

stylelint-processor-styled-components를 제거하고 @stylelint/postcss-css-in-js customSyntax를 사용합니다.

@drakang4 drakang4 requested a review from a team as a code owner November 5, 2021 05:02
@drakang4 drakang4 self-assigned this Nov 5, 2021
@giwan-dev giwan-dev added this to the v3.0.0-rc.1 milestone Nov 5, 2021
@giwan-dev
Copy link
Contributor

stylelint-config-standard는 따로 패키지를 설치할 필요는 없는 건가요?

@drakang4
Copy link
Contributor Author

drakang4 commented Nov 5, 2021

@zprime0920 그걸 빠트렸네요.. 추가했습니다.

giwan-dev
giwan-dev previously approved these changes Nov 5, 2021
Copy link
Contributor

@giwan-dev giwan-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@drakang4 drakang4 force-pushed the feature/stylelint-config-standard branch from 5badb1d to 62d53de Compare November 5, 2021 11:18
@drakang4 drakang4 requested review from a team and giwan-dev November 5, 2021 11:24
@drakang4 drakang4 changed the title stylelint-config-standard 사용 stylelint 14 업데이트 및 stylelint-config-standard 사용 Nov 5, 2021
@drakang4
Copy link
Contributor Author

drakang4 commented Nov 5, 2021

원래 그저 stylelint-config-recommended -> stylelint-config-standard 였던 것에 덧붙여서 stylelint 관련 다른 이슈도 함께 해결하는 PR로 변경합니다.

@drakang4 drakang4 changed the title stylelint 14 업데이트 및 stylelint-config-standard 사용 stylelint 14 업데이트 및 stylelint-config 변경 Nov 5, 2021
Copy link
Contributor

@giwan-dev giwan-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README에 fix 명령어 추가하라는 안내도 작성 부탁드립니당!

stylelint.js Show resolved Hide resolved
@drakang4 drakang4 requested review from giwan-dev and a team November 7, 2021 16:22
giwan-dev
giwan-dev previously approved these changes Nov 8, 2021
@giwan-dev giwan-dev requested a review from a team November 8, 2021 00:36
polysiya
polysiya previously approved these changes Nov 8, 2021
@drakang4
Copy link
Contributor Author

drakang4 commented Nov 8, 2021

canary release

@drakang4
Copy link
Contributor Author

drakang4 commented Nov 8, 2021

release-canary

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

v0.0.0-83d8f79 has been published!

@drakang4 drakang4 dismissed stale reviews from polysiya and giwan-dev via 04d73de November 8, 2021 06:21
@drakang4
Copy link
Contributor Author

drakang4 commented Nov 8, 2021

프로젝트들에 올려보고 rule 몇가지 추가합니다.

overrides는 기본 설정에 추가되는 규칙이기 때문에 중복된 설정도 제거합니다.

@drakang4 drakang4 requested review from giwan-dev, polysiya and a team November 8, 2021 06:29
@drakang4 drakang4 merged commit 81e9794 into main Nov 9, 2021
@drakang4 drakang4 deleted the feature/stylelint-config-standard branch November 9, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants