Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade package due to security flaw in eslint-utils@1.4.1 #5

Merged
merged 1 commit into from Aug 27, 2019
Merged

Upgrade package due to security flaw in eslint-utils@1.4.1 #5

merged 1 commit into from Aug 27, 2019

Conversation

majoravery
Copy link
Contributor

@dazlious
Copy link
Member

why the next major? have you run yarn upgrade-interactive?

@dazlious
Copy link
Member

we can also use the resolutions options in package.json

@dazlious
Copy link
Member

have you tested that linting still works? If yes, we can ofc merge this

@majoravery
Copy link
Contributor Author

Because that's the only one that has a version of eslint-utils more than 1.4.1 eslint/eslint#12131. Also I didn't know about resolutions!

@majoravery majoravery merged commit cbd973d into master Aug 27, 2019
@majoravery majoravery deleted the fix/update-eslint branch August 27, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dazlious dazlious dazlious approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@majoravery @dazlious @spacemup