Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix hanging build #313

Merged
merged 1 commit into from Sep 10, 2021
Merged

chore: fix hanging build #313

merged 1 commit into from Sep 10, 2021

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Sep 10, 2021

Resolves this problem: #311 (comment)

because of this problem: rollup/plugins#983

and I still don't get why you didn't commit the lock file for the main repo. I think that caused Github Actions to hangs because typescript will search for its' newest version instead of the one that pointed on the package.json. See this and this

let me know if you think of something else.

@talentlessguy talentlessguy merged commit 94875e2 into tinyhttp:master Sep 10, 2021
@talentlessguy
Copy link
Member

@all-contributors add @aldy505 for fix

@allcontributors
Copy link
Contributor

@talentlessguy

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@aldy505 aldy505 deleted the chore/build branch September 10, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants