Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[must_use] to Response struct #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JarredAllen
Copy link

(feel free to close if you disagree with me that this is a desirable feature)

I just had a bug-hunting session that resulted in me accidentally writing code:

fn handle_request(request: Request) {
    if <"If-None-Match" header with matching ETag was sent> {
        Response::empty(304);
    }
    request.respond(Response::new(..)).unwrap();
}

when I meant to write the code:

fn handle_request(request: Request) {
    if <"If-None-Match" header with matching ETag was sent> {
        request.respond(Response::empty(304)).unwrap();
        return;
    }
    request.respond(Response::new(..)).unwrap();
}

This attribute will prevent that from happening (though it is backwards-incompatible, so this probably should wait for the next major release).

(feel free to close if you disagree with me that this is a desirable feature)

I just had a bug-hunting session that resulted in me accidentally writing code:

```rust
fn handle_request(request: Request) {
    if <"If-None-Match" header with matching ETag was sent> {
        Response::empty(304);
    }
    request.respond(Response::new(..)).unwrap();
}
```

when I meant to write the code:

```rust
fn handle_request(request: Request) {
    if <"If-None-Match" header with matching ETag was sent> {
        request.respond(Response::empty(304)).unwrap();
        return;
    }
    request.respond(Response::new(..)).unwrap();
}
```

This attribute will prevent that from happening (though it is backwards-incompatible, so this probably should wait for the next major release).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant