Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssl-native-tls feature allowing using native-tls as an SSL backend #241

Merged
merged 2 commits into from May 16, 2023

Conversation

zvolin
Copy link
Contributor

@zvolin zvolin commented May 13, 2023

Closes #240.
native-tls is a crate that will pick the platforms native TLS implementation depending on the chosen build target

native-tls is a crate that will pick the platforms native
TLS implementation depending on the chosen build target
@zvolin
Copy link
Contributor Author

zvolin commented May 13, 2023

It seems that rustls no longer builds with 1.56. Should I bump MSRV on CI? and if so, what version would you consider?
https://github.com/tiny-http/tiny-http/actions/runs/4965923670/jobs/8887421498#step:4:28

@puhtaytow
Copy link

Awesome job! 🎉

@bradfier
Copy link
Member

@zvolin rustls specifies 1.57 now, if we can target that we should. If that is now too difficult because other upstream dependencies are doing the 'last six months' thing we might need to consider that instead.

Please feel free to bump the MSRV in the CI and docs and stick such a commit in this PR.

rustls targets 1.57 and is a significant enough dependency that we
should track it.
@bradfier
Copy link
Member

Turns out I can push to your branch!

@bradfier bradfier merged commit e221563 into tiny-http:master May 16, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use rust-native-tls instead of openssl directly
3 participants