Remove the 'static requirement on TestRequest::with_path #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruuda
changed the title
With 'static, one can only use static string slices, which makes it impossible to test with urls generated at runtime, such as ones generated by a fuzzer. This change is backwards-compatible, because it only relaxes the requirements on `with_path`, and although the type of the field changed, that field is not exposed. This doesn't incur an extra copy either. The copy was already there, it only got moved out of `into` and into `with_path` now.
bradfier
force-pushed
the
test-no-static-path
branch
from
3568e88
to
ab255a5
Compare
|
Looks like a bit of a bug in Github Actions here where it's requiring an old version of a matrix to pass. I'll merge anyway, sorry it took a while I was waiting for a green check to appear! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
'static, one can only use static string slices, which makes it impossible to test with urls generated at runtime, such as onesgenerated by a fuzzer. We can drop the
'staticrequirement to enable this use case.This change is backwards-compatible, because it only relaxes the requirements on
with_path, and although the type of the field changed, that field is not exposed.This does not incur an extra copy either. The copy was already there, it only got moved out of
fromand intowith_pathnow.