Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system version of Go #582

Merged
merged 1 commit into from Jan 19, 2022
Merged

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Jan 19, 2022

Description

Drop go from shell.nix (for now) and use the system's go binary.

Why is this needed

CI is currently breaking because of conflicting go versions.
The better fix would be cutting over fully to nix in CI or reverting this commit once actions/setup-go#175 is merged and released.

How Has This Been Tested?

CI

How are existing users impacted? What migration steps/scripts do we need?

CI isn't broken and PRs can be merged.

Signed-off-by: Micah Hausler <mhausler@amazon.com>
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Jan 19, 2022
@mmlb
Copy link
Contributor Author

mmlb commented Jan 19, 2022

Pretty sure I'll have to merge this manually once github lets me.

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #582 (04a8431) into main (b18b238) will increase coverage by 1.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
+ Coverage   34.76%   36.01%   +1.24%     
==========================================
  Files          44       44              
  Lines        3348     3207     -141     
==========================================
- Hits         1164     1155       -9     
+ Misses       2085     1959     -126     
+ Partials       99       93       -6     
Impacted Files Coverage Δ
http-server/http_handlers.go 6.80% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08f56c...04a8431. Read the comment docs.

@mmlb mmlb merged commit 96cbe60 into tinkerbell:main Jan 19, 2022
@mmlb mmlb deleted the fix-ci-nix-vs-system-go branch January 19, 2022 16:37
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants