Skip to content

Commit

Permalink
Use window.location directly instead of parsing into URL
Browse files Browse the repository at this point in the history
  • Loading branch information
timneutkens committed Nov 14, 2022
1 parent c10ac68 commit e5eca75
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/next/client/components/app-router.tsx
Expand Up @@ -136,7 +136,8 @@ function Router({
// location.href is read as the initial value for canonicalUrl in the browser
// This is safe to do as canonicalUrl can't be rendered, it's only used to control the history updates in the useEffect further down in this file.
typeof window !== 'undefined'
? createHrefFromUrl(new URL(window.location.href))
? // window.location does not have the same type as URL but has all the fields createHrefFromUrl needs.
createHrefFromUrl(window.location as unknown as URL)
: initialCanonicalUrl,
}
}, [children, initialCanonicalUrl, initialTree])
Expand Down

0 comments on commit e5eca75

Please sign in to comment.