Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tracing code to core without impacting bundle size #1

Closed
wants to merge 1 commit into from

Conversation

timfish
Copy link
Owner

@timfish timfish commented Sep 28, 2022

This was created on top of the hub-to-core migration PR (getsentry#5823) which further moves all the runtime agnostic tracing code to core too.

All I'm really doing here is moving the source files over and fixing up all the imports/exports.

  • Since none of the core code references any of the moved tracing code, bundling results in exactly the same browser bundle as before
  • This builds on top of another unmerged PR, the full changelog from master is huge
  • The tests don't pass because I haven't made an attempt to move them
  • All that's left in tracing is the node/browser specific code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant