Skip to content

Commit

Permalink
Drop setting webhook gvk explicitly in envtest
Browse files Browse the repository at this point in the history
webhookConfig.SetGroupVersionKind is not needed anymore with
kubernetes-sigs/controller-runtime#1665
  • Loading branch information
timebertt committed Oct 14, 2021
1 parent 5d7d61b commit 59c805a
Showing 1 changed file with 2 additions and 10 deletions.
Expand Up @@ -117,11 +117,7 @@ func getValidatingWebhookConfig() *admissionregistrationv1.ValidatingWebhookConf
},
}

webhookConfig := seedadmissioncontroller.GetValidatingWebhookConfig(nil, service)
// envtest doesn't default the webhook config's GVK, so set it explicitly
webhookConfig.SetGroupVersionKind(admissionregistrationv1.SchemeGroupVersion.WithKind("ValidatingWebhookConfiguration"))

return webhookConfig
return seedadmissioncontroller.GetValidatingWebhookConfig(nil, service)
}

func getMutatingWebhookConfig() *admissionregistrationv1.MutatingWebhookConfiguration {
Expand All @@ -131,9 +127,5 @@ func getMutatingWebhookConfig() *admissionregistrationv1.MutatingWebhookConfigur
},
}

webhookConfig := gardenerkubescheduler.GetMutatingWebhookConfig(clientConfig)
// envtest doesn't default the webhook config's GVK, so set it explicitly
webhookConfig.SetGroupVersionKind(admissionregistrationv1.SchemeGroupVersion.WithKind("MutatingWebhookConfiguration"))

return webhookConfig
return gardenerkubescheduler.GetMutatingWebhookConfig(clientConfig)
}

0 comments on commit 59c805a

Please sign in to comment.