add an OwnedFormatItem to make it easier to store parsed format descriptions in a struct #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iptions in a struct
jhpratt
added
A-format-description
|
I was just going to make some changes myself before adding in the ability to use this for parsing and adding tests for coverage. I'm unable to push; do I have the necessary permissions?
|
jhpratt
force-pushed
the
main
branch
3 times, most recently
from
0ad9f47
to
e95ea6d
Compare
|
Looks like the automation hasn't caught this for some reason. Please provide an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example for my feature request in #429. I don't love how much duplication of code there is.
I think this would be better
OwnedFormatItemeither implementedBorrow<FormatItem<'_>>orAsRef<FormatItem<'_>>, but I didn't get either of those implemented. The former would also enable us to implementToOwnedcorrectly.