Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed solaris build #277

Closed
wants to merge 5 commits into from
Closed

fixed solaris build #277

wants to merge 5 commits into from

Conversation

AviKozokin
Copy link

Missing std::TryFrom prevented successful build on x86_64-sun-solaris target

@jhpratt
Copy link
Member

jhpratt commented Sep 16, 2020

Two relatively minor things:

  • Would you mind adding Solaris to CI? It should amount to a single line addition if the target has been around long enough.
  • If the Solaris target has been around since before TryFrom was stabilized, the import should be use standback::convert::TryFrom. This allows usage on older compilers, while maintaining forward compatibility.

@jhpratt jhpratt self-requested a review September 16, 2020 21:50
@jhpratt jhpratt mentioned this pull request Sep 22, 2020
Merged
@jhpratt jhpratt added the A-targets Area: support for various targets label Sep 22, 2020
@jhpratt
Copy link
Member

jhpratt commented Sep 24, 2020

Closing in favor of #278, which is now merged.

@jhpratt jhpratt closed this Sep 24, 2020
@jhpratt jhpratt added the C-duplicate Category: exact duplicate label Sep 24, 2020
@jhpratt jhpratt removed their request for review September 24, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-targets Area: support for various targets C-duplicate Category: exact duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AviKozokin @jhpratt