Integer conversion on Solaris and Illumos

[francescocarzaniga]

The library was not used anywhere and it prevented the build from running on Illumos, this fixes it as far as I can tell.

[jhpratt]

Duplicate of #277, which is awaiting a response from the author.

[francescocarzaniga]

Oops, this is embarrassing.

[jhpratt]

No worries! If you'd like to check and make the appropriate changes I noted on the other PR, I'll happily merge this one.

[francescocarzaniga]

I made the required changes to my branch, but this PR is closed. Want me to open a new one?

[jhpratt]

I'm on mobile now, but I'll look at it later today if you push the changes up.

[francescocarzaniga]

They have been pushed, but they don't show up on a closed PR afaik.

[jhpratt]

Quickly looking into things: it looks like I'm unable to reopen because I've force pushed to main since you forked (I know, bad habit). It looks like there's a workaround, as your commits surely don't cause any conflict.

Thank you! Sorry about the hassle.

[francescocarzaniga]

I've also force pushed to my PR branch. Let me know if you need me to revert before reopening.

[jhpratt]

Looks like my force-pushing isn't actually the issue here, as your branch includes ccd997e, the latest commit on this repo's main branch.

We've got a few options here:

1. You can create a new PR
2. I can cherry-pick the commit from your branch, which would still give you credit in the commit history.
3. Somehow figure out how to reopen this PR. I presume you'd have to dig through reflogs to find the original commit hash and force-push that.

I don't have a preference, so it's up to you.

[francescocarzaniga]

You should be able to reopen this PR now. If that's not the case, just go ahead with option 2.

[jhpratt]

Unfortunately I'm not able to for some reason. I'll reach out to GitHub to try and figure out why, since I see absolutely no reason for that to be the case now. If you push up the changes — again — I'll cherry-pick it.

[francescocarzaniga]

Got it. I've pushed the changes again.

[jhpratt]

Meh, managed to use the official GitHub CLI to merge it 😆

Whatever works I suppose.