Fix using new jsx transform in tests #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new jsx transform is not working in tests when run through react-app-rewired (the fail with "ReferenceError: React is not defined"). Ported over this change from create-react-app: facebook/create-react-app@2b1161b
|
@dawnmist any thoughts on merging this? I haven't been keeping from v2 forward. |
|
I haven't tried moving from v3 to v4 yet, but the code is matching what react-scripts itself is doing. I have checked it out and tested that things still work properly with react-scripts v3, so it is backwards-compatible/doesn't break things for people who haven't upgraded yet. |
dawnmist
approved these changes
Dec 2, 2020
This was referenced May 21, 2021
This was referenced Jun 1, 2021
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new jsx transform is not working in tests when run through react-app-rewired (they fail with "ReferenceError: React is not defined"). Ported over this change from create-react-app: facebook/create-react-app@2b1161b