Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix casting REAL type to STRING type (#16975) #17003

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #16975

What is changed and how it works?

Issue Number: Close #16974

ref pingcap/tidb#53129

What's Changed:

expression: fix casting REAL type to STRING type
- unify the behavior of converting real types to strings in tidb#53129 and tikv.
- use ryu lib in tikv to implement casting real type to str type.
- `if abs(num) >= 1e15 or (num is not zero and abs(num) < 1e-15)` then use decimal exponent format 

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix the incorrect result when casting REAL type to STRING type

Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented May 11, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gengliqi
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@solotzg
Copy link
Contributor

solotzg commented May 13, 2024

ref pingcap/tidb#53207

@solotzg
Copy link
Contributor

solotzg commented May 13, 2024

/cc @gengliqi

@ti-chi-bot ti-chi-bot bot requested a review from gengliqi May 13, 2024 02:30
@solotzg
Copy link
Contributor

solotzg commented May 13, 2024

/assign @solotzg

@solotzg
Copy link
Contributor

solotzg commented May 13, 2024

/cc @wshwsh12

@ti-chi-bot ti-chi-bot bot requested a review from wshwsh12 May 13, 2024 04:04
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label May 13, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 13, 2024
@gengliqi
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 24db5a2

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 13, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit ca6e66e into tikv:release-8.1 May 13, 2024
3 checks passed
solotzg added a commit to solotzg/tikv that referenced this pull request May 14, 2024
ti-chi-bot bot pushed a commit that referenced this pull request May 14, 2024
close #16974

Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. contribution Type: PR - From contributors ok-to-test release-note size/XL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/cherry-pick-for-release-8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants