In-memory engine: add metrics for different types of iteration operations #16997
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
@afeinberg: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| self.collects_stats(); | ||
| if self.valid { | ||
| self.local_stats.bytes_read += (self.key().len() + self.value().len()) as u64; | ||
| self.local_stats.number_db_seek_found += 1; |
There was a problem hiding this comment.
I think the block of update local_stats can be put in one function, even though the number_xxx is different. One way is to have the mutable reference parameter for number_xxx
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@LykxSassinator: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 234caf2
|
What is changed and how it works?
Issue Number: Ref #16141
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note