Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWNERS: Auto Sync OWNERS files from community membership #16973

Merged
merged 3 commits into from May 22, 2024

Conversation

ti-chi-bot
Copy link
Member

Check List

Tests

  • No need to test
    • I checked and no code files have been changed.

skip-checks: true
Signed-off-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Copy link
Contributor

ti-chi-bot bot commented May 9, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • zhangjinpeng87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member Author

/release-note-none

@wuhuizuo
Copy link
Contributor

wuhuizuo commented May 9, 2024

/retest


------------

     Summary [ 373.007s] 1992 tests run: 1991 passed (6 flaky), 1 failed, 1972 skipped

   FLAKY 2/3 [   1.439s] tests::failpoints cases::test_pd_client_legacy::test_reconnect_limit

   FLAKY 2/3 [   1.441s] tests::failpoints cases::test_pending_peers::test_on_check_busy_on_apply_peers

   FLAKY 2/3 [   1.787s] tests::integrations raftstore::test_replication_mode::test_sync_recover_joint_state

   FLAKY 3/3 [   0.685s] tests::integrations raftstore::test_stale_read::test_resolved_ts_after_destroy_peer::test_raftstore_v2_new_node_cluster

   FLAKY 2/3 [   3.839s] tests::integrations raftstore::test_witness::test_witness_conf_change

   FLAKY 2/3 [   0.424s] tikv storage::txn::scheduler::tests::test_flow_control_trottle_deadline

  TRY 3 FAIL [  15.217s] tests::integrations server::server::test_restart_grpc_service



--- TRY 3 STDOUT:        tests::integrations server::server::test_restart_grpc_service ---

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label May 11, 2024
@wuhuizuo
Copy link
Contributor

Ref: #17004

OWNERS Outdated
- you06
- youjiali1995
- YuJuncen
- zhangjinpeng1987
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zhangjinpeng87

OWNERS Outdated Show resolved Hide resolved
@wuhuizuo
Copy link
Contributor

/assign wuhuizuo

Co-authored-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: Jinpeng Zhang <zzzhangjinpeng@gmail.com>
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 22, 2024
@zhangjinpeng87
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

@zhangjinpeng87: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 3800fe5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit b90493e into master May 22, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M skip-issue-check status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants