Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-memory engine: add metrics for range count #16971

Merged
merged 6 commits into from May 14, 2024

Conversation

SpadeA-Tang
Copy link
Member

What is changed and how it works?

Issue Number: Ref #16141

What's Changed:

add metrics for range count

It shows the different types of range count:
image

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Copy link
Contributor

ti-chi-bot bot commented May 9, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LykxSassinator
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

SpadeA-Tang and others added 2 commits May 10, 2024 13:00
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

@afeinberg: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label May 13, 2024
Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: Spade  A <71589810+SpadeA-Tang@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 14, 2024
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
@SpadeA-Tang
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented May 14, 2024

@SpadeA-Tang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 14, 2024

This pull request has been accepted and is ready to merge.

Commit hash: fae27c4

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 14, 2024
@SpadeA-Tang
Copy link
Member Author

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit 06eed73 into tikv:master May 14, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XXL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants