New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split_controller : split region based on hot keys and print key info #16965
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @mittalrishabh. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
if let Some(hottest_key_range) = hottest_key_range { | ||
recorder.update_hottest_key_range(hottest_key_range); | ||
key_ranges = vec![hottest_key_range]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One risk of doing this is that, due to one less sampling, the final number of regions to be split may increase. In this case, when a hotspot appears, increasing the number of regions may bring additional side effects, such as increasing the number of tasks or gRPC poll times, thereby affecting performance. We should conduct some tests on this change before merging it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i raised this github PR #17010 only for logging. Let me know how it looks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you using the hottest key range inside top_cpu_usage(). Shouldn't we do sampling over there.
What is changed and how it works?
Issue Number: Close #xxx
What's Changed:
It is splitting the range based on hot keys and printing the region keys in the message
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note