Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_backup: store pending region info when giving up retry (#16624) #16955

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #16624

What is changed and how it works?

Issue Number: Close #16469, Ref #16554

What's Changed:
This PR rearranged the lifetime of a observed region.
For now, we will try to keep it in subscription tracker from Start until End, even the start itself is failed.
So the RefreshObserver will be able to find and start its observe as expected.

This also added a test case for verifying #16554 has been fixed in master.


Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fixed a bug that may cause PiTR failed to observe the region.

close tikv#16469, ref tikv#16554

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Copy link
Contributor

ti-chi-bot bot commented May 7, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YuJuncen
Copy link
Contributor

Close it for now... Maybe use #17067

@YuJuncen YuJuncen closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants