*: remove prost support #11099
*: remove prost support #11099
Conversation
Since it's not used in production, remove it to reduce dependencies and codes. To fully remove prost, we still need pprof to support protobuf-codec. See also tikv#10905. Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
|
awesome, this can simplify our code a lot. I hope we can advance this. |
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
|
Some code recently merged from master include prost related code like https://github.com/BusyJay/tikv/blob/remove-prost-codec/components/cdc/tests/failpoints/test_endpoint.rs#L15. And some comments (in coprocessor) about prost is invalid. They can be easily found by searching for "prost". The rest lgtm. |
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
|
Why not remove protobuf-rs? Is there any public discussion about this decision? |
You mean |
|
Oh, I see. You mean why not choose prost-codec instead of protobuf-codec? The problems adapting prost-codec are
I personally prefer protobuf-codec because it has been tested and used in production for quite a long time. If we are going to only keep one codec, protobuf-codec is obviously the safest choice. |
ti-chi-bot
added
status/LGT1
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
| @@ -931,7 +931,11 @@ impl<E: Engine, L: LockManager> Scheduler<E, L> { | |||
| SCHED_THROTTLE_TIME.observe(start.saturating_elapsed_secs()); | |||
| return; | |||
| } | |||
| async_std::task::sleep(Duration::from_millis(1)).await; | |||
| GLOBAL_TIMER_HANDLE | |||
| .delay(std::time::Instant::now() + Duration::from_millis(1)) | |||
There was a problem hiding this comment.
LGTM. Better to reuse the now but seems not easy
|
/merge |
|
@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: f2f0169
|
|
@BusyJay: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Problem Summary:
Since it's not used in production, remove it to reduce dependencies and
codes.
To fully remove prost, we still need pprof to support protobuf-codec.
See also #10905.
Check List
Tests
Release note