Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust toolchain to nightly-2021-04-15 #10023

Merged
merged 14 commits into from
Apr 19, 2021
Merged

Update rust toolchain to nightly-2021-04-15 #10023

merged 14 commits into from
Apr 19, 2021

Conversation

andylokandy
Copy link
Contributor

@andylokandy andylokandy commented Apr 14, 2021 •
edited

What problem does this PR solve?

Fix #9444
Closes #10020

Release note

  • No release note

@andylokandy andylokandy changed the title Update rust toolchain to nightly-2021-01-16 Update rust toolchain to nightly-2021-03-25 Apr 14, 2021
@andylokandy
Update rust toolchain to nightly-2021-03-25
c7e60da 
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@BusyJay
Copy link
Member

BusyJay commented Apr 14, 2021

I thought current version was chosen for #9765.

@andylokandy
Copy link
Contributor Author

@BusyJay This has been fixed by rust-lang/rust#83412

BusyJay
BusyJay reviewed Apr 14, 2021
View reviewed changes
Cargo.toml Show resolved Hide resolved
@andylokandy
Fix cliipy
ba15030 
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@ti-chi-bot ti-chi-bot added size/XL and removed size/M labels Apr 14, 2021
BusyJay
BusyJay reviewed Apr 14, 2021
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@sticnarf
Copy link
Contributor

@andylokandy As rust-lang/rust#84130 is merged, do you think we can move to a more recent toolchain?

@andylokandy
Copy link
Contributor Author

andylokandy commented Apr 15, 2021 •
edited

@andylokandy As rust-lang/rust#84130 is merged, do you think we can move to a more recent toolchain?

rustdoc seems to be broken again in the latest nightly...

@andylokandy
address comment
18912cb 
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@andylokandy
update to nightly-2021-04-15
cc5ed23 
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@andylokandy
format
0296806 
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@andylokandy andylokandy changed the title Update rust toolchain to nightly-2021-03-25 Update rust toolchain to nightly-2021-04-15 Apr 15, 2021
@andylokandy
fix ci
4c48a03 
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@andylokandy
fix ci
47af51e 
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@andylokandy
Copy link
Contributor Author

/test

@andylokandy
address comment
cb02e0d 
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
sticnarf
sticnarf reviewed Apr 15, 2021
View reviewed changes
fuzz/targets/mod.rs Outdated Show resolved Hide resolved
@andylokandy
address comment
6b97234 
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Apr 16, 2021
@andylokandy
Copy link
Contributor Author

interesting... it waked up...

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • sticnarf
  • zhongzc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Apr 16, 2021
@zhongzc
Copy link
Contributor

zhongzc commented Apr 16, 2021

/merge

@ti-chi-bot
Copy link
Member

@zhongzc: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ada0dd0

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Apr 16, 2021
@sticnarf
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@sticnarf: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@andylokandy
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@andylokandy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@andylokandy andylokandy removed the status/can-merge Status: Can merge to base branch label Apr 16, 2021
@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Apr 16, 2021
@zhongzc zhongzc removed the status/can-merge Status: Can merge to base branch label Apr 19, 2021
@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Apr 19, 2021
@andylokandy
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@andylokandy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@andylokandy
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot
Copy link
Member

@andylokandy: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@andylokandy
Copy link
Contributor Author

/test

@ti-chi-bot ti-chi-bot merged commit bfff12a into tikv:master Apr 19, 2021
@sticnarf sticnarf mentioned this pull request Apr 19, 2021
Merged
@andylokandy andylokandy deleted the toolchain branch April 22, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BusyJay BusyJay BusyJay left review comments

@sticnarf sticnarf sticnarf left review comments

@zhongzc zhongzc zhongzc approved these changes

Assignees
No one assigned
Labels
size/XL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make doc is broken
5 participants
@andylokandy @BusyJay @sticnarf @ti-chi-bot @zhongzc