Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#695 - Link liburing.a statically if present. #724

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

subains
Copy link

@subains subains commented Oct 12, 2022

RocksDB enables IO_URING support by default and if the liburing dev files are present it creates a link dependency against liburing.a.

Signed-off-by: Sunny Bains sunny.bains@pingcap.com

RocksDB enables IO_URING support by default and if the liburing dev files are present
it creates a link dependency against liburing.a.

Signed-off-by: Sunny Bains <sunny.bains@pingcap.com>
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: subains <sunny.bains@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants