Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo/examples: add required-features annotations #511

Merged
merged 1 commit into from May 3, 2024

Conversation

irevoire
Copy link
Contributor

Hey,

I think we could use the required features field in the cargo.toml to improve the general experience / error messages when trying to run an example which requires a specific feature

Signed-off-by: Tamo <tamo@meilisearch.com>
@irevoire irevoire force-pushed the improve-example-with-features branch from b0c7707 to 1cb4cce Compare January 17, 2024 16:40
@lucab lucab changed the title Let the cargo.toml know which example requires which features cargo/examples: add required-features annotations May 3, 2024
Copy link
Member

@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM!

@lucab lucab merged commit b7e8745 into tikv:master May 3, 2024
7 checks passed
@lucab lucab mentioned this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants