Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export inner MetricVecBuilder structs #490

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MrCroxx
Copy link
Member

@MrCroxx MrCroxx commented May 11, 2023

Signed-off-by: MrCroxx mrcroxx@outlook.com

This PR exports MetricVecBuilder types, with which users can easily build customized tools.

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx
Copy link
Member Author

MrCroxx commented May 11, 2023

In risingwave#9756 I built self-managed metrics generic types with the inner builder types. IMO exporting the inner builder helps a lot. Is It okay to export them to all user or is there any better way to achieve it? Thanks a lot. 🙏

@TennyZhuang
Copy link

You should also bump the MSRV in the CI file.

Copy link

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@MrCroxx
Copy link
Member Author

MrCroxx commented May 12, 2023

Seems a new version of indirect dependency requires the new rust version. 🤔

@MrCroxx
Copy link
Member Author

MrCroxx commented May 12, 2023

@nickelc PTAL 🙏 If this PR is reasonable. Thanks a lot.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrCroxx
Copy link
Member Author

MrCroxx commented May 15, 2023

@lucab PTAL

@nickelc
Copy link
Contributor

nickelc commented May 15, 2023

The changes look fine.

Seems a new version of indirect dependency requires the new rust version. thinking

The dev dependency rayon 1.7 requires Rust 1.59 and the indirect dependency
security-framework v2.9.0 now requires Rust 1.60.

$ cargo tree --target all -i security-framework --features push
security-framework v2.9.0
└── native-tls v0.2.11
    ├── hyper-tls v0.5.0
    │   └── reqwest v0.11.17
    │       └── prometheus v0.13.3 (/projects/various/rust-prometheus)
    ├── reqwest v0.11.17 (*)
    └── tokio-native-tls v0.3.1
        ├── hyper-tls v0.5.0 (*)
        └── reqwest v0.11.17 (*)

@MrCroxx
Copy link
Member Author

MrCroxx commented May 17, 2023

@nickelc Thanks for help. Should I pin the dependency to the version that meets the MSRV(1.57) requires or update MSRV to a higher version?

@lucab
Copy link
Member

lucab commented May 17, 2023

@MrCroxx thanks for the patch! Let's bump the MSRV, 1.60 sounds like a good target.
Could you please do that in a separate PR? I'll review and merge that one, so that we can first unblock CI and then get to the rest of changes later.

@MrCroxx
Copy link
Member Author

MrCroxx commented May 17, 2023

@nickelc Could you please do that in a separate PR? I'll review and merge that one, so that we can first unblock CI and then get to the rest of changes later.

Sure~

Done with #491 .

@MrCroxx
Copy link
Member Author

MrCroxx commented May 17, 2023

Besides, would you like to publish a new version of this lib after this PR is merged?

@MrCroxx
Copy link
Member Author

MrCroxx commented May 18, 2023

@nickelc Sorry to bother you again. Can this PR be merged?

@MrCroxx
Copy link
Member Author

MrCroxx commented Sep 6, 2023

@lucab Hi, any updates? Can this PR be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants