Add a "push-no-tls" feature, for HTTP-only push support #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Yarbrough <brandony@gmail.com>
Signed-off-by: Brandon Yarbrough <brandony@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been putting together a little performance prober that uses rust-prometheus to push its results. My prober makes extensive use of some specialized native TLS libraries, and getting them to link nicely with reqwest's TLS library dependencies hasn't been working for me.
Then I realized that, by default, prometheus's pushgateway uses HTTP, so I figured that it would make sense for there to be an option for rust-prometheus's push support to not require those libraries. I've put together a new feature flag that enables push but does not require reqwest's TLS support.