Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Replace lazy_static with once_cell #450

Closed
wants to merge 3 commits into from
Closed

Feature: Replace lazy_static with once_cell #450

wants to merge 3 commits into from

Conversation

jaudiger
Copy link

@jaudiger jaudiger commented Jul 30, 2022

Hi @lucab,

As suggested in #448, I did the migration from the lazy_static library to once_cell library.

I hope I didn't forget anything, let me know ! I also fixed a few warnings reported by clippy (I did it in another commit).

If there is anything else I could do, to help to merge this PR, ping me ! For example, I'm not sure, about having pushed the proto_model.rs file
Thanks in advance.

@jaudiger
Copy link
Author

@lucab , the CI seems to not pass due to the usage of Rust edition 2021 in one of the transient dependencies… I was going to open a such issue, using edition 2021 instead of 2018 seems to be required those days, since lot of projects already did the migration. What do you think about that ?

@jaudiger
Copy link
Author

jaudiger commented Aug 8, 2022

Hi @lucab, do you have any feedback on this MR?

@lucab
Copy link
Member

lucab commented Sep 8, 2022

Thanks for the PR! I did recently merge some CI/linting fixes that may spare you a lot of headaches here, you may try rebasing to current master and see if it helps. That way we likely don't need to switch to 2021 edition here. Also, CI requires signoffs on all commits here.
Rest of the changes looks good. I'd need to double-check whether this has implications on the semver/API side.

@jaudiger
Copy link
Author

jaudiger commented Sep 8, 2022

@lucab thanks, I just rebased my MR on your latest commit. And I signed off my commits.

I also lower the restriction of the once_cell version to "^1.0" instead of "^1.13".

@jaudiger
Copy link
Author

Hi @lucab, any news regarding the implication of semver with those changes?

Signed-off-by: Jérémy Audiger <jeremy.audiger@ioterop.com>
Signed-off-by: Jérémy Audiger <jeremy.audiger@ioterop.com>
Signed-off-by: Jérémy Audiger <jeremy.audiger@ioterop.com>
@jaudiger jaudiger closed this by deleting the head repository Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants