RFC: Maintain incremental analyze result #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
w41ter
reviewed
Dec 27, 2021
| } | ||
| ``` | ||
|
|
||
| * When a TiKV receives an analyze request it will check the cache and applied index of this region. If the cache data exists and `applied_index` of the cache equals to the current `applied_index` of this region, it means that the region has never write any user data or split. |
There was a problem hiding this comment.
If the cache data exists and
applied_indexof the cache equals to the currentapplied_indexof this region, it means that the region has never write any user data or split.
So if any member changes, this cache will be invalied?
There was a problem hiding this comment.
Member changes? Do you mean that TiKV add one peer for this region?
There was a problem hiding this comment.
Conf change would not make cache invalid.
There was a problem hiding this comment.
I will try some trick method to avoid some conf change(include member changed or leader transfer) making the cache invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Little-Wallace bupt2013211450@gmail.com