Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize import format #339

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Normalize import format #339

wants to merge 3 commits into from

Conversation

Connor1996
Copy link
Member

@Connor1996 Connor1996 commented Sep 18, 2023 •
edited

Normalize import format by the rule which is used by TiKV

@Connor1996
normalize import format
96d0a8f 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996
Copy link
Member Author

PTAL as well @LykxSassinator

LykxSassinator
LykxSassinator approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@LykxSassinator LykxSassinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited

Codecov Report

Patch coverage is 99.00% of modified lines.

Files Changed Coverage
src/codec.rs ø
src/consistency.rs ø
src/env/default.rs ø
src/env/log_fd/plain.rs ø
src/env/log_fd/unix.rs ø
src/env/mod.rs ø
src/env/obfuscated.rs ø
src/errors.rs ø
src/file_pipe_log/format.rs ø
src/file_pipe_log/log_file.rs ø
... and 20 more

📢 Thoughts on this report? Let us know!.

@LykxSassinator LykxSassinator mentioned this pull request Sep 19, 2023
Open
tabokie
tabokie reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@tabokie tabokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add format to stable CI and see if it can pass too. This crate is used not limited to nightly compiler.

@Connor1996
check format on stable toolchain
949e94e 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996
force stable
eeb3a35 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabokie tabokie tabokie left review comments

@LykxSassinator LykxSassinator LykxSassinator approved these changes

@tonyxuqqi tonyxuqqi Awaiting requested review from tonyxuqqi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Connor1996 @LykxSassinator @tabokie