Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add some etcd pannel #7999

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Mar 29, 2024

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    image

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and Yisaer March 29, 2024 03:55
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Merging #7999 (74e18f4) into master (2c20897) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7999      +/-   ##
==========================================
+ Coverage   73.60%   73.61%   +0.01%     
==========================================
  Files         436      436              
  Lines       48476    48476              
==========================================
+ Hits        35679    35688       +9     
+ Misses       9739     9731       -8     
+ Partials     3058     3057       -1     
Flag Coverage Δ
unittests 73.61% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx
Copy link
Member

rleungx commented Apr 1, 2024

How do they help diagnose the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants