Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update minitrate-opentelemetry to latest opentelemetry versions #213

Merged
merged 1 commit into from
May 6, 2024

Conversation

rrichardson
Copy link
Contributor

This upgrades to opentelemetry 0.22, opentelemetry_sdk 0.22.1 and otlp: 0.15 and tweaks the corresponding API usage to match

Copy link
Collaborator

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongzc
Copy link
Collaborator

zhongzc commented Apr 30, 2024

Hello and thank you for your contribution! @rrichardson

It looks like your PR has not passed the DCO check. To fix this, please follow these steps:

  1. Pull your branch locally with git fetch origin pull/213/head:your-branch-name and git checkout your-branch-name
  2. Rebase your commits with sign-off by running git rebase HEAD~1 --signoff
  3. Force push the changes back to your branch with git push --force-with-lease origin your-branch-name

Make sure your commit messages contain a "Signed-off-by" line. It should look like this: Signed-off-by: Your Name <your-email@example.com>

Reference this check for more details.

Also, it needs to resolve failed test and format check.

Thank you!

@rrichardson rrichardson force-pushed the master branch 2 times, most recently from f93fb9e to e90a950 Compare May 3, 2024 04:17
…1 and otlp: 0.15 and tweak the corresponding API usage to match

Signed-off-by: Rick Richardson <rick.richardson@gmail.com>
Signed-off-by: Rick Richardson <ririchardson@tesla.com>
@rrichardson
Copy link
Contributor Author

Ok. DCO check seems to pass.
I have made some minor tweaks, formatted, and successfully run cargo test --workspace --all-features --no-fail-fast

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8934056674

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.835%

Totals Coverage Status
Change from base Build 8922318718: 0.0%
Covered Lines: 1732
Relevant Lines: 2197

💛 - Coveralls

@zhongzc zhongzc merged commit 9dc5c99 into tikv:master May 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants