fix issue of doesn't fast fail request when no available connections #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs520 <crazycs520@gmail.com>
crazycs520
force-pushed
the
fix-no-available-conn-bug0
branch
from
41790d1
to
a886b76
Compare
MyonKeminta
approved these changes
May 13, 2024
crazycs520
added a commit
to crazycs520/client-go
that referenced
this pull request
May 14, 2024
…ikv#1339) Signed-off-by: crazycs520 <crazycs520@gmail.com>
cfzjywxk
pushed a commit
that referenced
this pull request
May 14, 2024
…1339) (#1341) * fix issue of doesn't fast fail request when no available connections (#1339) Signed-off-by: crazycs520 <crazycs520@gmail.com> * refine error msg (#1338) * refine error msg Signed-off-by: crazycs520 <crazycs520@gmail.com> * refine Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix test Signed-off-by: crazycs520 <crazycs520@gmail.com> --------- Signed-off-by: crazycs520 <crazycs520@gmail.com> --------- Signed-off-by: crazycs520 <crazycs520@gmail.com>
13 tasks
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref pingcap/tidb#53222
https://github.com/tikv/client-go/pull/1098/files#diff-289d0ab3e9da9a88db8dcf8ed7095af6756da3ea8da38212b352742a83d93ba2L383
If do not cancel the request in time, the upper layer will wait until it times out, and we should cancel requests when no available connections and let the upper layer try another replica again.
Before This PR:
Benchmark test with stop 1 tikv store. Many slow query execution time exceed 1 min.
This PR:
Many slow query execution time is less than 25s.