Support actively requesting update health feedback information by calling RPC to TiKV #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling RPC to TiKV Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
MyonKeminta
force-pushed
the
m/request-health-feedback
branch
from
510b51d
to
2fd1e93
Compare
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
…uest-health-feedback
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
…uest-health-feedback
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
…minta/client-go into m/request-health-feedback
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
|
cc @crazycs520 PTAL |
cfzjywxk
reviewed
May 21, 2024
|
@crazycs520 @zyguan PTAL |
zyguan
approved these changes
May 23, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests will be added later. Let's see if this approach is acceptable now...
It seems possible to use the
BatchCommandsEmptyRequestto do this, but as it's designed for test purpose, and there are some special handlings that I don't understand in client-go (such asCallRPCfunction in client-go directly returns an empty response for it without accessing TiKV), I think a better idea would be adding a new API, so I added aRequestHealthFeedbackUpdate: The new RPC request is finally named
GetHealthFeedbackand is now a complete API that supports to be used in both batched & non-batched mode. And it has a special behavior, which is how it's being made use of in current implementation: If it's called in batched RPC mode, the response batch (BatchCommandsResponse) will also carry the feedback info.Ref: tikv/tikv#16297
Requires: