make experimental improvements to replica selector #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zyguan
commented
Jan 10, 2024
zyguan
commented
- pick avoid too frequent logs #1100
- [stale read] support increasing timeout when retry leader
- [stale read] support disabling retry follower when leader is unavailable
Signed-off-by: zyguan <zhongyangguan@gmail.com>
|
@zyguan @crazycs520 @MyonKeminta @you06 |
crazycs520
reviewed
May 11, 2024
internal/locate/region_request.go
Outdated
Comment on lines
92
to
93
| selectorExpOpts ReplicaSelectorExperimentalOptions | ||
| selectorExpOptsLock sync.RWMutex |
There was a problem hiding this comment.
How about use atomic.Value to avoid use global mutex.
Signed-off-by: zyguan <zhongyangguan@gmail.com>
Signed-off-by: zyguan <zhongyangguan@gmail.com>
crazycs520
approved these changes
May 14, 2024
|
@MyonKeminta @cfzjywxk PTAL |
cfzjywxk
approved these changes
May 14, 2024
cfzjywxk
merged commit 18d0dab
into
tikv:tidb-6.5-with-kv-timeout-feature
7 of 9 checks passed
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.