Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: data wrapper to wrap the raw value in the underlying storage #206

Merged
merged 1 commit into from Apr 20, 2022

Conversation

himank
Copy link
Collaborator

@himank himank commented Apr 20, 2022

No description provided.

@himank himank force-pushed the valueWrapper branch 2 times, most recently from 47af9cd to af03185 Compare April 20, 2022 00:16
@himank himank linked an issue Apr 20, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #206 (bc0b371) into main (484eee6) will decrease coverage by 0.65%.
The diff coverage is 32.97%.

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   39.85%   39.20%   -0.66%     
==========================================
  Files          35       36       +1     
  Lines        3136     3367     +231     
==========================================
+ Hits         1250     1320      +70     
- Misses       1724     1872     +148     
- Partials      162      175      +13     
Impacted Files Coverage Δ
query/aggregation/aggregation.go 44.00% <ø> (ø)
server/transaction/session.go 12.32% <10.00%> (ø)
server/transaction/manager.go 9.57% <22.22%> (ø)
store/kv/kv.go 26.45% <25.33%> (-33.55%) ⬇️
internal/data.go 39.50% <39.50%> (ø)
server/metadata/encoding/dictionary.go 50.55% <50.00%> (ø)
store/kv/fdb.go 58.40% <68.75%> (ø)
server/metadata/encoding/schema.go 66.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 484eee6...bc0b371. Read the comment docs.

internal/data.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
Makefile Show resolved Hide resolved
server/metadata/encoding/dictionary.go Outdated Show resolved Hide resolved
internal/data.go Outdated Show resolved Hide resolved
@himank himank merged commit 23c760f into main Apr 20, 2022
@himank himank deleted the valueWrapper branch April 20, 2022 22:56
@tigrisdata-argocd-bot
Copy link
Collaborator

🎉 This PR is included in version 1.0.0-alpha.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tigrisdata-argocd-bot
Copy link
Collaborator

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value encoding
5 participants