Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace standard JSON with jsoniter #318

Merged
merged 2 commits into from Jun 3, 2023

Conversation

ankitsridhar16
Copy link
Contributor

Description

This PR introduces jsoniter to the go client and uses jsoniter for operations like Marshal, Unmarshal but for operations like RawMessage and Number we still use encoding/json

Issue

#265

@ankitsridhar16 ankitsridhar16 force-pushed the refactor/jsoniter branch 2 times, most recently from 4d2b9a8 to ee71eb8 Compare June 1, 2023 18:59
@ankitsridhar16 ankitsridhar16 marked this pull request as ready for review June 1, 2023 18:59
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Patch coverage: 76.00% and no project coverage change.

Comparison is base (19993ca) 84.93% compared to head (d763342) 84.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   84.93%   84.93%           
=======================================
  Files          37       37           
  Lines        3406     3406           
=======================================
  Hits         2893     2893           
  Misses        365      365           
  Partials      148      148           
Impacted Files Coverage Δ
driver/grpc.go 88.02% <0.00%> (ø)
driver/search_grpc.go 93.63% <0.00%> (ø)
search/index.go 84.21% <50.00%> (ø)
tigris/collection.go 70.40% <50.00%> (ø)
schema/schema.go 84.90% <75.00%> (ø)
fields/read.go 92.30% <100.00%> (ø)
fields/update.go 96.10% <100.00%> (ø)
filter/filter.go 84.21% <100.00%> (ø)
schema/tag.go 94.24% <100.00%> (ø)
search/request.go 89.36% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@efirs efirs merged commit d1a4583 into tigrisdata-archive:main Jun 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants