add definition for state attribute of system.network.connections (ope…

…n-telemetry#2663)
tigrannajaryan · Jul 18, 2022 · 1fd2db2 · 1fd2db2
1 parent b74458a
commit 1fd2db2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -57,6 +57,8 @@ release.
   ([#2594](https://github.com/open-telemetry/opentelemetry-specification/pull/2594))
 - Add semantic conventions for JVM buffer pool usage
   ([#2650](https://github.com/open-telemetry/opentelemetry-specification/pull/2650)).
+- Improve the definition of `state` attribute for metric `system.network.connections`
+  ([#2663](https://github.com/open-telemetry/opentelemetry-specification/pull/2663))
 
 ### Compatibility
 

diff --git a/specification/metrics/semantic_conventions/system-metrics.md b/specification/metrics/semantic_conventions/system-metrics.md
@@ -148,7 +148,7 @@ perf counter (similar for Writes)
 | system<!--notlink-->.network.io.receive         | Bytes received                                                                            | By            | Counter                                           | Int64      | device        | (identifier)                                                                                   |
 | system.network.connections                      |                                                                                           | {connections} | UpDownCounter                                     | Int64      | device        | (identifier)                                                                                   |
 |                                                 |                                                                                           |               |                                                   |            | protocol      | tcp, udp, [etc.](https://en.wikipedia.org/wiki/Transport_layer#Protocols)                      |
-|                                                 |                                                                                           |               |                                                   |            | state         | [e.g. for tcp](https://en.wikipedia.org/wiki/Transmission_Control_Protocol#Protocol_operation) |
+|                                                 |                                                                                           |               |                                                   |            | state         | If specified, SHOULD be one of: close, close_wait, closing, delete, established, fin_wait_1, fin_wait_2, last_ack, listen, syn_recv, syn_sent, time_wait. A stateless protocol MUST NOT set this attribute. |
 
 <sup>1</sup> Measured as: