Skip to content

Commit

Permalink
Rename Span Event name to short_name
Browse files Browse the repository at this point in the history
This is part of the alignment effort defined here open-telemetry/opentelemetry-specification#622

The comment added clarifies the semantics, but I believe this is compatible
with our previous understanding and doe not change that understanding.
  • Loading branch information
Tigran Najaryan committed May 26, 2020
1 parent 28e2774 commit 2e18bdc
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions opentelemetry/proto/trace/v1/trace.proto
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,11 @@ message Span {
// time_unix_nano is the time the event occurred.
fixed64 time_unix_nano = 1;

// name of the event.
// This field is semantically required to be set to non-empty string.
string name = 2;
// Short event identifier that does not contain varying parts. short_name describes
// what happened (e.g. "ProcessStarted"). Recommended to be no longer than 50
// characters. Not guaranteed to be unique in any way. Typically used for filtering
// and grouping purposes in backends. This field is optional.
string short_name = 2;

// attributes is a collection of attribute key/value pairs on the event.
repeated opentelemetry.proto.common.v1.AttributeKeyValue attributes = 3;
Expand Down

0 comments on commit 2e18bdc

Please sign in to comment.