fix typos #357
Open
fix typos #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
commented
Apr 23, 2024
ccoVeille
commented
- Format files before working on them
- Fix JSON acronym
- Fix typos and style
- Use backtick for JSON node name, not quotes
gjson_test.go was formatted with gofumpt
An acronym is written in capital.
|
Hi @tidwall Is there anything you need from me before reviewing my PR? I'm asking because I may also work on a code review based on golangci-lint input. I wanted to start with a simple PR to see if you were open for PR contributions. I also, contributed to tidwall/sjson#82 And I intended to open a code review on sjson too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.