Add ID field for sounds #1073
Merged
Add ID field for sounds #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the path and the contents of a notification sound could conceivably change without the sound being semantically different. For example, `ding.mp3` could get renamed to `ding1.mp3`. Or a developer may re-encode `ding.mp3` to make it sound better. In both cases, we need some sort of ID to keep a handle on the sound and know what to play.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the path and the contents of a notification sound could conceivably change without the sound being semantically different.
For example,
ding.mp3could get renamed toding1.mp3. Or a developer may re-encodeding.mp3to make it sound better.In both cases, we need some sort of ID to keep a handle on the sound and know what to play.