Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting Incorrect Usage of EfiSignatureList #561

Merged
merged 2 commits into from
May 31, 2024

Conversation

Flickdm
Copy link
Contributor

@Flickdm Flickdm commented May 16, 2024

An authenticated variable may contain only a single EfiSignatureList. However, they may contain multiple EfiSignatureLists otherwise known as EfiSignatureDatabase.

This change corrects that misconception

@Flickdm Flickdm requested a review from Javagedes May 16, 2024 20:50
@Javagedes
Copy link
Contributor

This looks fine, just needs to be updated to fix the unit tests

@Flickdm Flickdm force-pushed the fix/auth_variable_support branch from cfb40ec to 9804240 Compare May 31, 2024 05:38
@Flickdm Flickdm force-pushed the fix/auth_variable_support branch from 9804240 to 74136e7 Compare May 31, 2024 05:42
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.45%. Comparing base (ce85203) to head (74136e7).
Report is 56 commits behind head on master.

Files Patch % Lines
.../uefi/authenticated_variables_structure_support.py 83.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   81.43%   81.45%   +0.01%     
==========================================
  Files          56       56              
  Lines        7514     7542      +28     
==========================================
+ Hits         6119     6143      +24     
- Misses       1395     1399       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Javagedes Javagedes added this to the v0.21.6 milestone May 31, 2024
@Javagedes Javagedes merged commit ba08f64 into tianocore:master May 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants