path_utilities.py: Prevent path case modification in GetContainingModules() #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 78.42% // Head: 78.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 78.42% 78.51% +0.08%
==========================================
Files 91 91
Lines 10125 10167 +42
==========================================
+ Hits 7941 7983 +42
Misses 2184 2184
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ules() Closes tianocore#204 Updates `Edk2Path.GetContainingModules()` to preserve case the case for each absolute path returned in the list of absolute paths. This allows callers dependent on case comparison to get the expected result. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
update_edk2path_path_str_format
branch
from
c6f7552
to
e920a29
Compare
Javagedes
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #204
Updates
Edk2Path.GetContainingModules()to preserve case the casefor each absolute path returned in the list of absolute paths.
This allows callers dependent on case comparison to get the expected
result.
Also adds a new test case used to verify this change:
test_get_containing_modules_path_format()Used to confirm the case in paths returned from
Edk2Path.GetContainingModules()Signed-off-by: Michael Kubacki michael.kubacki@microsoft.com