Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edk2_initialize: add edk2_init invocable #560

Open
wants to merge 8 commits into
base: feature/1.0.0
Choose a base branch
from

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented May 19, 2023

Add the edk2_init invocable, which replaces edk2_setup and edk2_ci_setup. stuart_init is able to initialize both repositories and submodules.

Integration instructions:

  • import from edk2toolext.invocables.edk2_initialize rather than .edk2_setup or .edk2_ci_setup inside the configuration file
  • import Submodule and/or Repository instead of RequiredSubmodule
  • Where the parent class is specified, switch from SetupSettingsManager or CiSetupSettingsManager to InitializeSettingsManager
  • Use get_required_repositories and get_required_submodules instead of GetDependencies and GetRequiredSubmodules respectively
  • Use Submodule instead of RequiredSubmodule and Repository instead of a dictionary.

Closes #556

@Javagedes Javagedes force-pushed the 1.0.0-stuart_init branch 2 times, most recently from ec7fb6f to 0a7e26d Compare May 19, 2023 23:41
@Javagedes Javagedes linked an issue May 19, 2023 that may be closed by this pull request
@Javagedes Javagedes added this to the 1.0.0 milestone May 19, 2023
@Javagedes Javagedes self-assigned this May 19, 2023
@Javagedes Javagedes changed the title edk2_initialize: add edk2_initialize edk2_initialize: add edk2_init invocable May 19, 2023
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #560 (ae7d55e) into feature/1.0.0 (eb45afc) will decrease coverage by 0.36%.
The diff coverage is 88.02%.

❗ Current head ae7d55e differs from pull request most recent head 4c1a3b3. Consider uploading reports for the commit 4c1a3b3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           feature/1.0.0     #560      +/-   ##
=================================================
- Coverage          78.74%   78.39%   -0.36%     
=================================================
  Files                 47       46       -1     
  Lines               4785     4776       -9     
=================================================
- Hits                3768     3744      -24     
- Misses              1017     1032      +15     
Impacted Files Coverage Δ
edk2toolext/environment/repo_resolver.py 92.37% <ø> (+1.61%) ⬆️
edk2toolext/invocables/edk2_initialize.py 88.02% <88.02%> (ø)

... and 28 files with indirect coverage changes

@Javagedes Javagedes force-pushed the 1.0.0-stuart_init branch 3 times, most recently from 28f84a1 to 36c4e42 Compare July 17, 2023 21:41
Add the edk2_initialize invocable, which replaces edk2_setup and
edk2_ci_setup. stuart_init is able to initialize both repositories and
submodules.

Merges edk2_setup and edk2_ci_setup tests. Updates documentation.

Integration instructions:
* import from edk2toolext.invocables.edk2_initialize rather than
  .edk2_setup or .edk2_ci_setup inside the configuration file
* import Submodule and/or Repository instead of RequiredSubmodule
* Where the parent class is specified, switch from SetupSettingsManager
  or CiSetupSettingsManager to InitializeSettingsManager
* Use get_required_repositories and get_required_submodules instead of
  GetDependencies and GetRequiredSubmodules respectively
* Use Submodule instead of RequiredSubmodule and Repository instead of
  a dictionary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: merge and rename stuart setup / ci_setup
1 participant