edk2_stuart_pr_eval: Improve robustness of path comparisons #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paths are currently returned from various functions and compared in `get_packages_to_build()`. This change updates the paths to be represented with `Path` objects so path comparison can leverage the `Path` object equality method to perform the comparison more robustly than with raw strings. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #346 +/- ##
==========================================
- Coverage 70.50% 70.46% -0.05%
==========================================
Files 48 48
Lines 4798 4801 +3
==========================================
Hits 3383 3383
- Misses 1415 1418 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Javagedes
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths are currently returned from various functions and compared in
get_packages_to_build(). This change updates the paths to berepresented with
Pathobjects so path comparison can leveragethe
Pathobject equality method to perform the comparison morerobustly than with raw strings.
Signed-off-by: Michael Kubacki michael.kubacki@microsoft.com