Plugin Loader Updates [Rebase & FF] #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
==========================================
- Coverage 70.59% 69.66% -0.94%
==========================================
Files 48 42 -6
Lines 4792 4790 -2
==========================================
- Hits 3383 3337 -46
- Misses 1409 1453 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Javagedes
reviewed
Nov 8, 2022
Javagedes
reviewed
Nov 8, 2022
Javagedes
reviewed
Nov 8, 2022
Javagedes
approved these changes
Nov 8, 2022
spbrogan
reviewed
Nov 8, 2022
spbrogan
approved these changes
Nov 8, 2022
Fixes tianocore#337 Plugins are currently loaded in the `_load()` function in plugin_manager.py by using the `imp` standard library: https://docs.python.org/3/library/imp.html The first sentence of the library documentation states the following: ``` Deprecated since version 3.4, will be removed in version 3.12: The imp module is deprecated in favor of importlib. ``` This means, `imp` will be removed in the next Python release. Therefore, this change updates the code to use `importlib` standard library as recommended by the `imp` documentation. The code follows the recipe recommended by the `importlib` documentation to directly load a Python source file as is the case when loading Python modules based on plugin descriptor information. https://docs.python.org/3/library/importlib.html#importing-a-source-file-directly Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Closes tianocore#338 Adds dynamically loaded plugin module directory paths to the system path so the plugin modules can import other modules relative to their path as they would if they were not dynamically loaded. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
plugin_loader_updates
branch
from
a5757dd
to
b7ee773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series makes two main changes:
Update usage of deprecated loading APIs
Fixes Plugin Loader dependency will be removed in Python 3.12 #337
Plugins are currently loaded in the
_load()function inplugin_manager.py by using the
impstandard library:https://docs.python.org/3/library/imp.html
The first sentence of the library documentation states the following:
This means,
impwill be removed in the next Python release.Therefore, this change updates the code to use
importlibstandardlibrary as recommended by the
impdocumentation.The code follows the recipe recommended by the
importlibdocumentation to directly load a Python source file as is the case
when loading Python modules based on plugin descriptor information.
https://docs.python.org/3/library/importlib.html#importing-a-source-file-directly
Add plugin module paths to system path
Closes [Feature]: Allow plugins to reference relative modules #338
Adds dynamically loaded plugin module directory paths to the system
path so the plugin modules can import other modules relative to their
path as they would if they were not dynamically loaded.