edk2_pr_eval.py: Build all packages on file change outside package [Rebase & FF] #327
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
==========================================
- Coverage 70.46% 70.42% -0.05%
==========================================
Files 48 48
Lines 4801 4804 +3
==========================================
Hits 3383 3383
- Misses 1418 1421 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Many of our integration tests are currently very picky when it comes to changes in files not associated with a particular package. Those will need to be updated. |
|
I'm working on the integration tests now. |
makubacki
force-pushed
the
enhance_pr_eval
branch
from
20ee61a
to
dce7935
Compare
Updated. As noted in the commit message, the tests will not pass until tianocore/edk2-pytool-library#186 is available. |
makubacki
force-pushed
the
enhance_pr_eval
branch
from
dce7935
to
0f9aa88
Compare
0.11.6 to 0.12.1 Changes: - path_utilities: Adjust GetContainingPackage() and Edk2Path behavior - path_utilities: Enhance Edk2Path.GetContainingModules() - path_utilities: Add an env variable to allow nested packages - path_utilities: Prevent path case modification in GetContainingModules() Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
enhance_pr_eval
branch
from
0f9aa88
to
ccb88bc
Compare
|
I preemptively moved the |
makubacki
changed the title
Because of that, I added a distinct commit to show the setup.py update. Please Rebase & FF to keep that separate. |
|
release pipeline is running now and should be out soon. |
makubacki
force-pushed
the
enhance_pr_eval
branch
from
ccb88bc
to
5025bdb
Compare
Updates `get_packages_to_build()` to return all possible packages if a file is modified outside a package. Originally, this was implemented behind a new argument with the default behavior unchanged. However, feedback indicated it would be easier to adopt without an argument and this would be acceptable behavior. This does mean some files, such as documentation files, could trigger packages to build that would have not previously built. However, the impact and frequency of this is considered minimal enough to not justify additional complexity. The change mainly focuses on files such as dependency trackers (e.g. PIP requirements, submodules), Python scripts, and other files that can impact overall build results. Requires tianocore/edk2-pytool-library#186. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
enhance_pr_eval
branch
from
5025bdb
to
e567be4
Compare
Updates
get_packages_to_build()to return all possible packages ifa file is modified outside a package.
Originally, this was implemented behind a new argument with the
default behavior unchanged. However, feedback indicated it would
be easier to adopt without an argument and this would be acceptable
behavior.
This does mean some files, such as documentation files, could trigger
packages to build that would have not previously built. However, the
impact and frequency of this is considered minimal enough to not
justify additional complexity. The change mainly focuses on files
such as dependency trackers (e.g. PIP requirements, submodules),
Python scripts, and other files that can impact overall build
results.
Requires tianocore/edk2-pytool-library#186.
Signed-off-by: Michael Kubacki michael.kubacki@microsoft.com