Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pydocstyle #325

Merged
merged 2 commits into from Nov 3, 2022
Merged

Add Pydocstyle #325

merged 2 commits into from Nov 3, 2022

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Nov 1, 2022

Adds PyDocStyle (google convention) to the PR Gates to enforce proper documentation in preparation for automatic documentation generation.

Brings all documentation in this repo in line with this convention.

This PR will be a REBASE&FF. The first commit adds the infrastructure for pydocstyle (pipelines, vscode settings, config settings, etc) while the second commit actually makes the compliance changes in this repo.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #325 (323b9cd) into master (c095824) will increase coverage by 0.28%.
The diff coverage is 93.87%.

❗ Current head 323b9cd differs from pull request most recent head 9844fb7. Consider uploading reports for the commit 9844fb7 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   70.27%   70.55%   +0.28%     
==========================================
  Files          41       42       +1     
  Lines        4744     4786      +42     
==========================================
+ Hits         3334     3377      +43     
+ Misses       1410     1409       -1     
Flag Coverage Δ
Linux 69.72% <93.87%> (?)
Windows_NT 70.49% <93.87%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xt/environment/plugintypes/dsc_processor_plugin.py 0.00% <0.00%> (ø)
edk2toolext/invocables/edk2_pr_eval.py 0.00% <0.00%> (ø)
...lext/environment/plugintypes/uefi_helper_plugin.py 50.00% <50.00%> (+1.51%) ⬆️
edk2toolext/base_abstract_invocable.py 81.33% <100.00%> (+0.25%) ⬆️
edk2toolext/bin/nuget.py 88.00% <100.00%> (+0.50%) ⬆️
edk2toolext/capsule/capsule_helper.py 92.06% <100.00%> (+0.06%) ⬆️
edk2toolext/capsule/capsule_tool.py 61.90% <100.00%> (+0.61%) ⬆️
edk2toolext/capsule/pyopenssl_signer.py 58.62% <100.00%> (+1.47%) ⬆️
edk2toolext/capsule/signing_helper.py 86.36% <100.00%> (+0.64%) ⬆️
edk2toolext/capsule/signtool_signer.py 56.81% <100.00%> (+0.49%) ⬆️
... and 34 more

@Javagedes Javagedes force-pushed the feature/pydocstyle branch 13 times, most recently from dd13068 to 9042dd5 Compare November 1, 2022 19:48
Adds Pydocstyle linting requirements using the google convention by
adding this linting to the PR gate. Updates developing.md documentation
and adds Pydocstyle linting to the vscode settings.
Updates all files to be in compliance with the google pydocstyle
convention.
@spbrogan spbrogan added the documentation Improvements or additions to documentation label Nov 2, 2022
@Javagedes Javagedes added this to the 0.20.0 milestone Nov 3, 2022
@Javagedes Javagedes self-assigned this Nov 3, 2022
@Javagedes Javagedes merged commit be0c149 into tianocore:master Nov 3, 2022
@Javagedes Javagedes deleted the feature/pydocstyle branch November 3, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants