Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dependabot.yml location #321

Merged

Conversation

Javagedes
Copy link
Contributor

Dependabot should be located at .github/ not .github/workflows as specified in here

@Javagedes Javagedes added this to the 0.19.1 milestone Oct 5, 2022
@Javagedes Javagedes added the bug Something isn't working label Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #321 (f37d7e2) into master (e5a2ecd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   70.34%   70.34%           
=======================================
  Files          41       41           
  Lines        4744     4744           
=======================================
  Hits         3337     3337           
  Misses       1407     1407           
Flag Coverage Δ
Linux 69.49% <ø> (ø)
Windows_NT 70.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@makubacki
Copy link
Member

To be clear, dependabot has never worked in this repo, right? Dependabot ran as an action and failed?

@Javagedes
Copy link
Contributor Author

To be clear, dependabot has never worked in this repo, right? Dependabot ran as an action and failed?

@makubacki Correct, I would receive the error specified in the link provided above. I had time today to look into it and fix the issue.

@makubacki
Copy link
Member

To be clear, dependabot has never worked in this repo, right? Dependabot ran as an action and failed?

@makubacki Correct, I would receive the error specified in the link provided above. I had time today to look into it and fix the issue.

Makes sense. Gave a void approval in show of support.

@Javagedes Javagedes modified the milestones: 0.19.1, 0.19.2 Oct 6, 2022
@Javagedes Javagedes modified the milestones: 0.19.2, 0.20.0 Nov 1, 2022
@Javagedes Javagedes merged commit bb936e7 into tianocore:master Nov 3, 2022
@Javagedes Javagedes deleted the personal/joeyvagedes/dependabot branch November 3, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants