Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicklela
Copy link

This change implements the blob transfer protocol used in OpenBmc documented here: https://github.com/openbmc/phosphor-ipmi-blobs

Cc: Abner Chang abner.chang@amd.com
Cc: Isaac Oram isaac.w.oram@intel.com
Cc: Abdul Lateef Attar AbdulLateef.Attar@amd.com
Cc: Nickle Wang nicklew@nvidia.com

@nicklela nicklela requested a review from changab April 11, 2023 13:48
@nicklela nicklela force-pushed the IpmiBlobTransfer branch 6 times, most recently from 0be2eff to 87f5699 Compare April 12, 2023 03:15
@nate-desimone
Copy link
Member

nate-desimone commented Sep 19, 2023

Hi @nicklela, the TianoCore project uses our mailing list for review and approval of code changes. Changes that only come via PR are not accepted. PRs are sometimes opened for the propose of convenience, but they are not the official review method. Please see this document for a discussion of how to send your code for review on the mailing list: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process#the-developer-process-for-the-edk-ii-project

@nicklela
Copy link
Author

Hi @nate-desimone

Yes, I had sent this code change to edk2-devel maillist for review. This is the discussion thread: https://edk2.groups.io/g/devel/topic/98212643#102863

Hi @nicklela, the TianoCore project uses our mailing list for review and approval of code changes. Changes that only come via PR are not accepted. PRs are sometimes opened for the propose of convenience, but they are not the official review method. Please see this document for a discussion of how to send your code for review on the mailing list: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process#the-developer-process-for-the-edk-ii-project

@nicklela nicklela force-pushed the IpmiBlobTransfer branch 7 times, most recently from 122c35b to 09a5145 Compare May 15, 2024 15:01
…tocol

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4773

This change implements the blob transfer protocol used in OpenBmc
documented here: https://github.com/openbmc/phosphor-ipmi-blobs

Signed-off-by: Nick Ramirez <nramirez@nvidia.com>
Co-authored-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Cc: Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>
Cc: Nhi Pham <nhi@os.amperecomputing.com>
Cc: Thang Nguyen OS <thang@amperemail.onmicrosoft.com>
Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants