Add filter configurations at a per-Source granularity #248
Conversation
There was a problem hiding this comment.
The changes for adding partial clones to submodules looks good as do the changes to define the partial clone strategy at a per level in the manifest file. Can we separate them into two separate commits?
Your commit message indicates that this is also addressing #247 the two partial clone methods are not really intended to be combined as such I would prefer to address this by making them mutually exclusive arguments, erroring out and letting the user make the correct choice.
Adds treeless="true" and blobless="true" as attributes to a Combination Source. Add arg --full to disable repo attributes. --treeless, --blobless, and --full args will disable the per-Source attributes. Allow up to one of --treeless, --blobless and --full args to be used per edkrepo clone. Related issues: tianocore#239 add filter configurations at a per-Source or per-Remote granularity tianocore#247 clone with both --treeless and --blobless encounter git error Signed-off-by: Nathaniel Haller <nathaniel.d.haller@intel.com>
ndhaller
force-pushed
the
treeless_blobless
branch
from
03b37d6
to
627c31f
Compare
treeless="true" and blobless="true" Source filter settings will apply to submodules if enableSubmodule="true" is also set on the Source. Signed-off-by: Nathaniel Haller <nathaniel.d.haller@intel.com>
Added a separate commit for the submodule change. |
Adds treeless="true" and blobless="true" as attributes to a Combination Source.
During edkrepo clone and checkout, if enableSubmodule="true" on the Combination Source, the filter setting applies to the submodules as well.
--treeless and treeless="true" have priority over --blobless and blobless="true" if multiple are used.
During edkrepo clone, --treeless and --blobless do not apply to the submodule filter settings.
Related issues:
#239
add filter configurations at a per-Source or per-Remote granularity
#247
clone with both --treeless and --blobless encounter git error